backport: readd global lock for postgres and the channeldb_kv table #10397
+62
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziggie1984
force-pushed
the
backport/add-back-globallock
branch
from
dd44b40 to
45ea9d6
Compare
ziggie1984
force-pushed
the
backport/add-back-globallock
branch
from
45ea9d6 to
6d99e68
Compare
Add two configuration options to control global lock usage for different postgres database backends: - ChannelDBWithGlobalLock: for channeldb access (default: false) - WalletDBWithGlobalLock: for wallet database access (default: true) These allow fine-grained control over which databases use global locks, rather than hardcoding the behavior. This is a temporary measure until the revocation log and wallet are migrated to native SQL and become fully concurrent-safe.
ziggie1984
force-pushed
the
backport/add-back-globallock
branch
2 times, most recently
from
1d1ccc7 to
e8a803b
Compare
Replace hardcoded WithGlobalLock assignment with configurable options wallet postgres backends. Also add the WithGlobalLock option to the channeldb table for postgres backends. Defaults: - channeldb: false (allow concurrent access) - wallet: true (maintain safe single-writer behavior) Users can now override these defaults via: - db.postgres.channeldb-with-global-lock - db.postgres.walletdb-with-global-lock This gives operators flexibility while maintaining safe defaults until full native SQL migration is complete. Moreover exclude db.postgres.walletdb-with-global-lock check in the sample config file script. We cannot easily check the correct default because we set it later in the LND startup sequence so we exclude it.
ziggie1984
force-pushed
the
backport/add-back-globallock
branch
from
e8a803b to
6bdfb1d
Compare
Collaborator
Author
|
short note here, this backport is a bit different to the master PR because we had to add the relativ sqldb reference here, since in master this reference to the local sqldb package was already present. |
saubyk
approved these changes
Dec 1, 2025
Roasbeef
reviewed
Dec 1, 2025
|
|
||
| // Use the local sqldb package for development. | ||
| // TODO(norbert): remove once sqldb package is tagged. | ||
| replace github.com/lightningnetwork/lnd/sqldb => ./sqldb |
Roasbeef
merged commit 4eaf57d
into
lightningnetwork:v0.20.x-branch
38 of 39 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports #10394